Skip to content

Improve PowerShell Extension termination experience#5380

Merged
andyleejordan merged 2 commits intoPowerShell:mainfrom
darlingtonogbuefi:fix/notification-settings-issue#5336
Apr 8, 2026
Merged

Improve PowerShell Extension termination experience#5380
andyleejordan merged 2 commits intoPowerShell:mainfrom
darlingtonogbuefi:fix/notification-settings-issue#5336

Conversation

@darlingtonogbuefi
Copy link
Copy Markdown
Contributor

PR Summary

This PR adds a configuration option to suppress PowerShell Extension terminal crash/restart notifications.

Reference issue: Allow disabling the "The PowerShell Extension terminal has stopped" notifications #5336

Currently, when the PowerShell Extension terminal is stopped (intentionally or otherwise), VS Code repeatedly shows notifications warning that IntelliSense will not work. While useful for new users, these notifications can become noisy for experienced users who intentionally close the terminal or are already aware of the consequences—especially now that the terminal is spawned more frequently (for example, when Copilot references PowerShell code).

This change introduces a user-configurable setting that allows disabling these notifications, keeping the notification area clean without affecting functionality.

Key points

Adds a new setting to opt out of PowerShell Extension terminal stopped/restart notifications

Default behavior remains unchanged (notifications are still shown unless disabled)

Improves user experience for advanced users without impacting discoverability for new users

PR Checklist

PR has a meaningful title

Summarized changes

[NA] PR has tests

This PR is ready to merge and is not work in progress

@darlingtonogbuefi
Copy link
Copy Markdown
Contributor Author

darlingtonogbuefi commented Jan 18, 2026 via email

@andyleejordan andyleejordan changed the title Added optional settings to suppress PowerShell Extension Terminal Stopped notifications - issue#5336 Improve PowerShell Extension termination experience Apr 8, 2026
darlingtonogbuefi and others added 2 commits April 8, 2026 11:08
We can now suppress the LSP library's duplicate notification,
and we provide a promptable action to suppress our own.
@andyleejordan andyleejordan force-pushed the fix/notification-settings-issue#5336 branch from 833a40d to cb1c05b Compare April 8, 2026 18:08
Copy link
Copy Markdown
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @darlingtonogbuefi you are quite right that we massively needed to improve this experience. Thank you for the inspiration. I've gone ahead and updated this PR with a few more things:

  • Switched the logic to "suppress" to match our existing suppression options
  • Added a "Do Not Show" action to the initial error message to change the suppress setting
  • Found that we can finally suppress the LSP library's own notifications too

@andyleejordan andyleejordan merged commit 0ce9094 into PowerShell:main Apr 8, 2026
4 checks passed
@darlingtonogbuefi
Copy link
Copy Markdown
Contributor Author

Hey @darlingtonogbuefi you are quite right that we massively needed to improve this experience. Thank you for the inspiration. I've gone ahead and updated this PR with a few more things:

  • Switched the logic to "suppress" to match our existing suppression options
  • Added a "Do Not Show" action to the initial error message to change the suppress setting
  • Found that we can finally suppress the LSP library's own notifications too

Hey @andyleejordan,
Thanks for the quick update! I really appreciate you incorporating the suggestions. The changes sound great, looking forward to seeing how this performs in action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants